Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MinervaAlwaysShowLanguageButton for solarawiki #3330

Merged
merged 2 commits into from Oct 28, 2020

Conversation

MusikAnimal
Copy link
Contributor

@MusikAnimal MusikAnimal commented Oct 28, 2020

No description provided.

Since there aren't usually different language editions of Miraheze wikis
@Universal-Omega
Copy link
Sponsor Member

Would probably be better to not change the default configuration values right now as the default values are usually the defaults for the extension, as such it should usually remain true since that's likely the default value of the extension.

@dmehus
Copy link
Contributor

dmehus commented Oct 28, 2020

We should consider adding this to ManageWiki in a future ManageWiki update, maybe. I know we do that for @Universal-Omega's Cosmos skin, so it might be helpful to have additional configuration settings for the other skins, perhaps.

@Universal-Omega
Copy link
Sponsor Member

We should consider adding this to ManageWiki in a future ManageWiki update, maybe. I know we do that for @Universal-Omega's Cosmos skin, so it might be helpful to have additional configuration settings for the other skins, perhaps.

Yeah, at the moment things are a bit chaotic with the 1.35 upgrade but eventually I have plans to add alot of popular configuration values to ManageWikiSettings with approval from John, of course.

@MusikAnimal
Copy link
Contributor Author

MusikAnimal commented Oct 28, 2020

Would probably be better to not change the default configuration values right now as the default values are usually the defaults for the extension, as such it should usually remain true since that's likely the default value of the extension.

Yes the default for Minerva is true. But how many Miraheze wikis are the same 'family' of wiki but different language? I was assuming this is not common. So https://meta.miraheze.org/wiki/Community_noticeboard?useskin=minerva for instance has a "Language" link at the top-left. There is no de.miraheze.org or fr.miraheze.org, etc. I'm also assuming the wikis would need to be tied together via Wikibase. But again, just assumptions :) I'm not really sure.

That said, should I change the default to true, and false for my wiki? I just wanted to make sure my justification for this change was clear.

@Universal-Omega
Copy link
Sponsor Member

Would probably be better to not change the default configuration values right now as the default values are usually the defaults for the extension, as such it should usually remain true since that's likely the default value of the extension.

Yes the default for Minerva is true. But how many Miraheze wikis are the same 'family' of wiki but different language? I was assuming this is not common. So https://meta.wikimedia.org/wiki/Mission?useskin=minerva for instance has a "Language" link at the top-left. There is no de.miraheze.org or fr.miraheze.org, etc. I'm also assuming the wikis would need to be tied together via Wikibase. But again, just assumptions :) I'm not really sure.

That said, should I change the default to true, and false for my wiki? I just wanted to make sure my justification for this change was clear.

Yes at least for now it would be preferable to only set it to false for your particular wiki. Thank you!

@MusikAnimal MusikAnimal changed the title disable MinervaAlwaysShowLanguageButton by default Disable MinervaAlwaysShowLanguageButton for solarawiki Oct 28, 2020
@paladox paladox merged commit a250f5f into miraheze:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants