-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
Create a directory-category for terminal emulators #101894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a directory-category for terminal emulators #101894
Conversation
This is a mostly cosmetical commit, in the sense it doesn't change the contents of any package, but reorganizes the overall Nixpkgs expressions. Terminal emulators are an ubiquitous tool for any Unix user; even the beginners are routinely familiarized to it. And, manifestly, there are many implementations of terminal emulators out there, from those traditionally made in C and C++ to those written in Haskell and Go. Terminal emulators deserve more highlight. This commit does that by creating a category for them.
The only errors(?) found here are trailing whitespaces. This implies everything is OK, the expressions weren't affected by its relocation. So, I will add a new commit only for this small fix. |
Should they also be grouped together in |
@berbiche you said in a sense they are all grouped in a contiguous place? Well, it is a bit controversial. The "ordered all-packages.nix" was lost a long time ago. It can certainly be done, but I am being more conservative here: I just get all references to terminal emulators and moved them. |
Some maintainers are still adhering to the "ordered all-packages.nix" (which happened to one of my contribution listed here 😄) and thus I bringing up the subject. |
@berbiche behold! |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/a-directory-category-for-terminal-emulators/9698/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'm the maintainer of termonad, and I remember that when I added termonad, I was surprised there wasn't already a category for terminal emulators.
Because editorconfig complains, and also why not to organize them "ascii-betically"?
The section |
I am now working on reorder this file. As I said before, it is a beautiful mess, and I will "fix" it. |
This is a mostly cosmetical commit, in the sense it doesn't change the contents
of any package, but reorganizes the overall Nixpkgs expressions.
Terminal emulators are an ubiquitous tool for any Unix user; even the beginners
are routinely familiarized to it. And, manifestly, there are many
implementations of terminal emulators out there, from those traditionally made
in C and C++ to those written in Haskell and Go.
Terminal emulators deserve more highlight. This commit does that by creating a
category for them.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)