Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eyewitness: init at v20201021.1 #101893

Closed
wants to merge 1 commit into from
Closed

eyewitness: init at v20201021.1 #101893

wants to merge 1 commit into from

Conversation

redvers
Copy link
Member

@redvers redvers commented Oct 28, 2020

Motivation for this change

EyeWitness is a tool that I use on a daily basis to evaluate large swathes of network services that I am responsible for. It is a headless application which takes as input a list of URLs and outputs screenshots and source-code for each item in the list.

To test:

nix-shell -p eyewitness
EyeWitness.py --single https://nixos.org/

(You can see example output of the above here: https://evil.red/2020-10-28_032409/report.html)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

@redvers Can you please fix the eval error?

called without required argument 'xlibs', at

@redvers redvers force-pushed the add_eyewitness branch 2 times, most recently from c23dfd2 to 380f674 Compare October 29, 2020 14:03
@redvers
Copy link
Member Author

redvers commented Oct 29, 2020

@redvers Can you please fix the eval error?

called without required argument 'xlibs', at

Fixed - AND it works on aarch64 swoon

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101893 run on x86_64-linux 1

1 package built:
  • eyewitness

@redvers
Copy link
Member Author

redvers commented Nov 6, 2020

@andir

andir
andir reviewed Nov 9, 2020
View reviewed changes
pkgs/tools/security/eyewitness/default.nix
firefox
geckodriver
xorg.xorgserver
python37
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what the best approach here is. Usually I just pass a single python script into these expressions. That one python version is generated via python3.withPackages (p: [ p.netaddr p.selenium … ] ).

  • We should probably avoid hard coding python version 3.7 if we can. Just using python 3 should be sufficient.
  • Why did you add pip as dependency? Does it try to install packages during runtime?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @FRidh on the matter of how we pass python envs these days.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still using python3.7 explicitly unless really required we should use python3 here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this part needs some revisiting.

@SuperSandro2000
Copy link
Member

Can you rebase this branch on master to fix the eval error?

@redvers
Copy link
Member Author

redvers commented Nov 23, 2020

Result of nixpkgs-review pr 101893 1

1 package built:
  • eyewitness

SuperSandro2000
SuperSandro2000 requested changes Dec 28, 2020
View reviewed changes
pkgs/tools/security/eyewitness/default.nix

stdenv.mkDerivation rec {
pname = "eyewitness";
version = "v20201021.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "v20201021.1";
version = "20201021.1";

pkgs/tools/security/eyewitness/default.nix
src = fetchFromGitHub {
owner = "FortyNorthSecurity";
repo = "EyeWitness";
rev = version;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = version;
rev = "v${version}";

pkgs/tools/security/eyewitness/default.nix
firefox
geckodriver
xorg.xorgserver
python37
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this part needs some revisiting.

SuperSandro2000
SuperSandro2000 reviewed Jan 18, 2021
View reviewed changes
pkgs/tools/security/eyewitness/default.nix

doCheck = false;

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

SuperSandro2000
SuperSandro2000 reviewed Jan 18, 2021
View reviewed changes
pkgs/tools/security/eyewitness/default.nix
homepage = "https://github.com/FortyNorthSecurity/EyeWitness";
maintainers = with maintainers; [ redvers ];
platforms = platforms.linux;
license = licenses.gpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpl3Plus or gpl3Only?

@fabaff
Copy link
Member

fabaff commented Feb 13, 2021

The latest release is v20210205.1.

Related to #81418

@redvers
Copy link
Member Author

redvers commented Feb 13, 2021

Thanks - I thought this PR was mothballed - I'll get to addressing the above issues a little later today.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft February 14, 2021 06:12
@stale
Copy link

stale bot commented Aug 13, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 13, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@redvers @SuperSandro2000 @fabaff @andir