kdeApplications: 20.08.1 -> 20.08.2 #101906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run on darwin: Not really interesting to be honest. Result of 2 packages marked as broken and skipped:
|
peterhoeg
force-pushed
the
u/kapps_20082
branch
2 times, most recently
from
d783c5f
to
66ebd1f
Compare
|
Result of 2 packages marked as broken and skipped:
1 package failed to build:
174 packages built:
|
|
|
|
Cc: @doronbehar @ttuegel |
doronbehar
requested changes
Oct 28, 2020
| @@ -21618,7 +21618,7 @@ in | |||
| kaddressbook kalzium kapptemplate kapman kate katomic | |||
| kblackbox kblocks kbounce | |||
| kcachegrind kcalc kcharselect kcolorchooser | |||
| kdenlive kdf kdialog kdiamond | |||
| kdeconnect-kde kdenlive kdf kdialog kdiamond | |||
There was a problem hiding this comment.
This change will conflict with #101369 .
There was a problem hiding this comment.
Sure, so either this PR or the other needs to be changed depending on which is merged first - there really is no way around that.
|
In general I think it'd be best to cook this in #101369 . |
10 tasks
Sure, feel free to include this as part of the other PR. |
Actually, come to think of it, I think we should just go ahead and get this in. I dropped the Otherwise, unless you have strong objections @doronbehar, I'll go ahead later today and merge this to avoid having too many pending PRs around the same area and as the 5.15 change is going to take some time by the looks of it. |
|
No strong objections. Considering this change is smaller then mine, and that @ttuegel is not that responsive regarding it, and the fact it doesn't conflict much and doesn't relate much to mine, it'd be better not to wait with this PR.
I do tend to think that probably 20.08.2 has better qt5.15 support that's why it'd be better to put these changes there, but merging these changes alone will probably not make things worse.
|
peterhoeg
force-pushed
the
u/kapps_20082
branch
from
0436486
to
753fa37
Compare
doronbehar
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Also moves kdeconnect in where it belongs.
nix-review is currently running.
Related: #101369
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)