Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pytorch: 1.6.0 -> 1.7.0 #101917

Merged
merged 1 commit into from Nov 11, 2020
Merged

python3Packages.pytorch: 1.6.0 -> 1.7.0 #101917

merged 1 commit into from Nov 11, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changelog:

https://github.com/pytorch/pytorch/releases/tag/v1.7.0

Todo: test CUDA build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from teh and thoughtpolice October 28, 2020 11:12
@danieldk
Copy link
Contributor Author

@ofborg build python37Packages.pytorch python38Packages.pytorch

@danieldk
Copy link
Contributor Author

danieldk commented Nov 2, 2020

AArch64 fails with

aten/src/ATen/native/cpu/GridSamplerKernel.cpp.DEFAULT.cpp:519:3: internal compiler error: Max. number of generated reload insns per insn is achieved (90)

Could be this issue:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96796

@danieldk danieldk mentioned this pull request Nov 2, 2020
Merged
10 tasks
danieldk added a commit to danieldk/nixpkgs that referenced this pull request Nov 2, 2020
@danieldk
gcc9: apply gcc PR 96796 to avoid cycling on certain subreg reloads
c81a429 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96796

This may have caused the AArch64 build failure of PyTorch in:

NixOS#101917
@danieldk
Copy link
Contributor Author

Updated to fix incorrect paths in CMake files.

@ofborg build python37Packages.pytorch python38Packages.pytorch

@danieldk danieldk merged commit 5e93492 into NixOS:master Nov 11, 2020
@danieldk danieldk deleted the pytorch-1.7.0 branch November 11, 2020 10:51
@danieldk
Copy link
Contributor Author

Edit: whoops, merged the wrong PR, too many tabs open.

I can revert this if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@teh teh Awaiting requested review from teh

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danieldk