Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud: 19.0.3 -> 19.0.4, 18.0.9 -> 18.0.10 #101923

Merged
merged 2 commits into from Nov 6, 2020
Merged

nextcloud: 19.0.3 -> 19.0.4, 18.0.9 -> 18.0.10 #101923

merged 2 commits into from Nov 6, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Oct 28, 2020 •
edited

Motivation for this change

Getting Nextcloud to stop informing me about updates.

Please backport this to 20.09 as Nextcloud doesn't support downgrades.

20.0.1 makes dashboard load faster and fixes a deadlock: https://nextcloud.com/blog/20-0-1-is-here-with-about-60-changes-get-your-update/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
Copy link
Member Author

KamilaBorowska commented Oct 28, 2020 •
edited

@ofborg build nextcloud20 nextcloud19 nextcloud18

I'm not sure if ofborg will be fine with building Nextcloud 18 because it's insecure, but eh, may as well list that.

@ofborg test nextcloud

@KamilaBorowska KamilaBorowska changed the title Nextcloud updates nextcloud: 20.0.0 -> 20.0.1, 19.0.3 -> 19.0.4, 18.0.9 -> 18.0.10 Oct 28, 2020
@KamilaBorowska
Copy link
Member Author

@ofborg test nextcloud.basic nextcloud.with-postgresql-and-redis nextcloud.with-mysql-and-memcached

@KamilaBorowska
Copy link
Member Author

Ran an update to Nextcloud 20.0.1 in production on my server: https://gitlab.com/KonradBorowski/xfix.pw/-/commit/287977e9f9957ebcec9e8067257e0b5b5a951cb4, no issues, everything works as it should.

bachp
bachp approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19.0.4 update is working without issues

@Ma27
Copy link
Member

Ma27 commented Nov 3, 2020

The 20.0.1 update is already in master from another PR, so it can be removed here. The rest seems fine IMHO.

@KamilaBorowska KamilaBorowska changed the title nextcloud: 20.0.0 -> 20.0.1, 19.0.3 -> 19.0.4, 18.0.9 -> 18.0.10 nextcloud: 19.0.3 -> 19.0.4, 18.0.9 -> 18.0.10 Nov 3, 2020
@KamilaBorowska
Copy link
Member Author

Sure, not like it matters either way, but may as well rebase newest master. I think git would remove already merged-in commits during merge process.

@ofborg ofborg bot requested a review from bachp November 3, 2020 10:37
@Ma27
Copy link
Member

Ma27 commented Nov 3, 2020

Just verified with git 2.28 that it would cause a merge conflict when using a trivial git merge, also both bumps would be in the history probably causing confusion. Not sure if GitHub is smart enough to actually resolve this.
IIRC what you describe only happens during a rebase.

@Ma27 Ma27 merged commit 115f769 into NixOS:master Nov 6, 2020
@Ma27
Copy link
Member

Ma27 commented Nov 6, 2020

Thanks! Ported to stable 24b3800, b1acf67.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@globin globin Awaiting requested review from globin

@schneefux schneefux Awaiting requested review from schneefux

@fpletz fpletz Awaiting requested review from fpletz

@bachp bachp Awaiting requested review from bachp

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KamilaBorowska @Ma27 @bachp