Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement splitString using builtins.split #100953

Merged
merged 1 commit into from Oct 20, 2020
Merged

Implement splitString using builtins.split #100953

merged 1 commit into from Oct 20, 2020

Conversation

AtnNn
Copy link
Contributor

@AtnNn AtnNn commented Oct 18, 2020 •
edited

Motivation for this change

splitString was slow and crashed on large strings, but it is still used over a hundred times in nixpkgs. Previously mentioned in:

Things done
  • Ran nix-instantiate --eval --strict lib/tests/misc.nix

infinisil
infinisil requested changes Oct 18, 2020
View reviewed changes
lib/strings.nix Outdated Show resolved Hide resolved
lib/default.nix Outdated Show resolved Hide resolved
@AtnNn AtnNn requested a review from infinisil October 18, 2020 13:20
infinisil
infinisil approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@infinisil infinisil merged commit a2fe9a7 into NixOS:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AtnNn @infinisil