Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validatePkgConfig: fix variable scope #100964

Merged
merged 1 commit into from Oct 19, 2020
Merged

validatePkgConfig: fix variable scope #100964

merged 1 commit into from Oct 19, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

validatePkgConfig failed due to a wrong variable scope, as reported in
issue #100834. This change corrects the variable scoping.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
validatePkgConfig: fix variable scope
48a20e9 
validatePkgConfig failed due to a wrong variable scope, as reported in
issue NixOS#100834. This change corrects the variable scoping.
@Ericson2314 Ericson2314 merged commit 7929891 into NixOS:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @Ericson2314