[20.09] pythonPackages.pymc3: fix build, init pythonPackages.fastprogress at 1.0.0 #100955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build python37Packages.pymc3 |
10 tasks
das-g
suggested changes
Oct 18, 2020
(modified cherry pick of commit 4a9dba6) some tricks are required to make this work because NixOS#93560 and NixOS#97597 didn't make it into this branch, but this example shows what is required to import theano from within a nix build environment on this branch.
(cherry picked from commit 9a09285)
(modified cherry-pick of commit 3c3295a)
risicle
force-pushed
the
ris-theano-tmpdir-redirect-fix-r20.09
branch
from
264840d
to
f447235
Compare
|
Er.. not sure if you're serious, but ok... |
|
Result of 10 packages built:
|
das-g
approved these changes
Oct 19, 2020
jonringer
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 100955 1
10 packages built:
- python27Packages.Lasagne
- python27Packages.Theano (python27Packages.TheanoWithoutCuda)
- python27Packages.TheanoWithCuda
- python37Packages.Theano (python37Packages.TheanoWithoutCuda)
- python37Packages.TheanoWithCuda
- python37Packages.fastprogress
- python37Packages.pymc3
- python38Packages.Theano (python38Packages.TheanoWithoutCuda)
- python38Packages.TheanoWithCuda
- python38Packages.fastprogress
|
@risicle BTW, just wanted to say thanks for working this all out. Have been reading through the various threads and can see this was quite a mess for you to straighten out. 👍 |
|
No problem - you got the real fix in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ZHF: #97479
This is a modified & combined backport of #99587 and #100867.
Because 20.09 is missing #97597 and #93560 (and I think including them at this stage might be a bit risky), importing/using
theanofrom within a nix build environment (i.e. withNIX_ENFORCE_PURITY=1) will only succeed if the tmpdir used is actually literally/tmp, which you can't really do from a sandboxed build. So this useslibredirectto convince the compiler wrapper we are actually working with/tmp.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)