Fix: [NoAI] don't notify caught exceptions #8331
Conversation
rptr
changed the title
|
Presumably this does still output for uncaught exceptions? |
|
https://i.imgur.com/dHSqlon.png AI code used: |
|
The -d script= possibility occured to me, but ideally it wouldn't show on the lowest level, since it's used by AI developers. At least I use that option. Not sure exactly what is printed for each level. I guess an alternative solution is/ was to catch all exceptions like before but filter out the call stacks somewhere in RunError/ ScriptController::Print. If the AI/Game Script Debug window was made more interactive at some point, this information could be folded/ hidden and interacted with. |
|
Also the reason I suggested AIError:PrintCallStack was to allow developers to still print the stack for debugging. |
|
I wouldn't expect it to be used by AI developers, tbh. It's all mostly just for internal debugging stuff. But you can just arbitrarily pick a level to display it at - there's no consistency between anything :p |
|
It's useful. I am coding an AI now (hence this patch), and it would be useful. Perhaps what I really want is a debugger... |
|
Ah, but it still prints the stack in the case of errors. Maybe it wouldn't be needed then. Disregard what I just said. |
|
So apparently that 1 line of code in sqvm.cpp wasn't needed after all. |
src/script/squirrel.cpp
Outdated
| SQBool notify_all = SQFalse; | ||
| if (_debug_script_level > 2) notify_all = SQTrue; | ||
| sq_notifyallexceptions(this->vm, notify_all); |
There was a problem hiding this comment.
some odd indentation going on here. Besides, perhaps:
| SQBool notify_all = SQFalse; | |
| if (_debug_script_level > 2) notify_all = SQTrue; | |
| sq_notifyallexceptions(this->vm, notify_all); | |
| sq_notifyallexceptions(this->vm, _debug_script_level > 2); |
?
Make _notifyallexceptions and error raising behave as expected
(1 LOC backport from https://github.com/albertodemichelis/squirrel trunk)
Set _notifyallexceptions to false to only call Squirrel::_RunError on uncaught exceptions