Does this also work on the older, still supported, releases?

@Mic92 I'm not sure if I'm missing something, but it doesn't seem to properly fix the original LDAP issue. I built a VM from your branch (rev c403ed445dbd3cf7f23d86ba0b8b35e8b9f10442) with the following config:

# cat vm.nix
{
  snens = { lib, pkgs, config, ... }: {
    networking.firewall.allowedTCPPorts = [ 80 ];
    services.nextcloud = {
      enable = true;
      hostName = "localhost";
      config = {
        adminpass = "root";
      };
    };
  };
}

And started it like this:

$ nixos-build-vms -I nixpkgs=$(pwd) vm.nix
$ QEMU_NET_OPTS=hostfwd=tcp::8080-:80 ./result/bin/nixos-run-vms

When I try to configure LDAP auth in the VM, I still get the following error:

snens # [  102.003163] nginx[739]: 2020/10/24 16:58:03 [error] 739#739: *92 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught Error: Class 'OC_JSON' not found in /nix/store/5ybb1r22wxqv92ix92igqp7ysvlyy1wx-nextcloud-20.0.1/apps/user_ldap/ajax/getConfiguration.php:30
snens # [  102.008149] nginx[739]: Stack trace:
snens # [  102.009502] nginx[739]: #0 {main}
snens # [  102.010688] nginx[739]:   thrown in /nix/store/5ybb1r22wxqv92ix92igqp7ysvlyy1wx-nextcloud-20.0.1/apps/user_ldap/ajax/getConfiguration.php on line 30" while reading response header from upstream, client: 10.0.2.2, server: localhost, request: "POST /apps/user_ldap/ajax/getConfiguration.php HTTP/1.1", upstream: "fastcgi://unix:/run/phpfpm/nextcloud.sock:", host: "localhost:8080"

Does this also work on the older, still supported, releases?

It does not change anything for older releases.

I applied now suggestions from nextcloud/documentation#2197 (comment) which is basically a revert of the changes before. Also I think ldap worked with the other hack.

Also I think ldap worked with the other hack.

@Mic92 which other hack?

Also I think ldap worked with the other hack.

@Mic92 which other hack?

The one you tested in a VM also worked on my server.

Oops sorry, I didn't realize that you pushed new changes after my last commit... LGTM, will merge/backport :)

Thanks! Ported to 20.09 as bae0cce, 1c50dc4.

Just a note: This leaves behind the major function unused.