test-driver.py: remove bufsize=1 from Popen calls #101538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you. I don't feel good merging this without having the bot posting success on a few test runs here. Can you start some test runs on this? |
|
@ofborg test bittorrent installer |
Ma27
approved these changes
Oct 24, 2020
flokli
approved these changes
Oct 24, 2020
|
@xfix can you please have a look why the tests.installer test failed on aarch64 linux? |
|
It failed because there is no test called @ofborg test bittorrent installer.simple acme |
|
Oh right, I need to rebase newest master to fix tests because of bc2188b. |
According to Python documentation [0], `bufsize=1` is only meaningful in
text mode. As we don't pass in an argument called `universal_newlines`,
`encoding`, `errors` or `text` the file objects aren't opened in text
mode, which means the argument is ignored with a warning in Python 3.8.
line buffering (buffering=1) isn't supported in binary mode,
the default buffer size will be used
This commit removes this warning that appared when using
interactive test driver built with `-A driver`. This is done by
removing `bufsize=1` from Popen calls.
The default parameter when unspecified for `bufsize` is `-1` which
according to the documentation will be interpreted as
`io.DEFAULT_BUFFER_SIZE`. As mentioned by a warning, Python already
uses default buffer size when providing `buffering=1` parameter for
file objects not opened in text mode.
[0]: https://docs.python.org/3/library/subprocess.html#subprocess.Popen
KamilaBorowska
force-pushed
the
test-driver-bufsize
branch
from
526b166
to
254d30d
Compare
|
@ofborg test bittorrent installer.simple acme |
Okay, I think this may have been caused by bc2188b actually. |
|
Okay installer.simple may be fixed by #101645, this isn't related to this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Python documentation,
bufsize=1is only meaningful in text mode. As we don't pass in an argument calleduniversal_newlines,encoding,errorsortextthe file objects aren't opened in text mode, which means the argument is ignored with a warning in Python 3.8.This commit removes this warning that appared when using interactive test driver built with
-A driver. This is done by removingbufsize=1from Popen calls.The default parameter when unspecified for
bufsizeis-1which according to the documentation will be interpreted asio.DEFAULT_BUFFER_SIZE. As mentioned by a warning, Python already uses default buffer size when providingbuffering=1parameter for file objects not opened in text mode.Motivation for this change
Fixing a warning.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)