gtk3: Use tracker3 for search #101537
Merged
gtk3: Use tracker3 for search #101537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: GNOME
Pantheon would be the perfect test bench for this 👍 (though they plan to use tracker in the future) |
worldofpeace
approved these changes
Oct 24, 2020
|
I believe if we merge this to gnome-3.38 we'll still get an eval for it? (I think things shouldn't go to staging untested) |
|
We need not only eval but also runtime testing, I would wait with this until next staging is merged. |
It was briefly mentioned in stdenv docs but since it interacts with wrapGAppsHook, it should be documented here.
|
Running gedit linked against this GTK on Ubuntu, the file chooser seems to work and even search does seem to show some recursive results. Though it does not seem to be complete and complains in the logs: |
|
Did not encounter any issues in NixOS VM either. |
This was referenced Dec 12, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream recommends to build GTK 3 with Tracker 3 enabled. Without it, according to my tests, the search only affects the current directory.
But previously
trackerdepended ongtk3throughlibsoup→sysprof→gtk3, which only got resolved in #101528, and, what is more, even now throughwrapGAppsHook. To resolve this, I createdwrapGAppsNoGuiHook, which does not propagate dependencies needed for graphical programs. I tried to document it, when I noticed GdkPixbuf loaders are not mentioned so I added a docs section before I forget.This is yet untested, will need to check what happens when user tries to search in GTK file dialogue on systems without Tracker D-Bus service.