Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.TestPerlTidy: 20200412 -> 20200930 #101550

Merged
merged 2 commits into from Oct 24, 2020
Merged

perlPackages.TestPerlTidy: 20200412 -> 20200930 #101550

merged 2 commits into from Oct 24, 2020

Conversation

zakame
Copy link
Member

@zakame zakame commented Oct 24, 2020 •
edited

Motivation for this change

https://metacpan.org/release/SHLOMIF/Test-PerlTidy-20200930
https://metacpan.org/release/SHANCOCK/Perl-Tidy-20201001

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zakame zakame requested a review from stigtsp as a code owner October 24, 2020 13:11
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101550 1

10 packages failed to build:
  • freecell-solver
  • gnome3.aisleriot
  • kdeApplications.kpat
  • perl530Packages.TaskFreecellSolverTesting
  • perl530Packages.TestPerlTidy
  • perl532Packages.DistZillaPluginBundleTestingMania
  • perl532Packages.DistZillaPluginTestCompile
  • perl532Packages.TaskFreecellSolverTesting
  • perl532Packages.TestPerlTidy
  • pysolfc
20 packages built:
  • perl530Packages.CLIHelpers
  • perl530Packages.DistZillaPluginBundleTestingMania
  • perl530Packages.DistZillaPluginTestCompile
  • perl530Packages.DistZillaPluginTestMinimumVersion
  • perl530Packages.DistZillaPluginTestPerlCritic
  • perl530Packages.PerlCritic
  • perl530Packages.PerlCriticMoose
  • perl530Packages.PerlMinimumVersion
  • perl530Packages.PerlTidy
  • perl530Packages.TestMinimumVersion
  • perl530Packages.TestPerlCritic
  • perl532Packages.CLIHelpers
  • perl532Packages.DistZillaPluginTestMinimumVersion
  • perl532Packages.DistZillaPluginTestPerlCritic
  • perl532Packages.PerlCritic
  • perl532Packages.PerlCriticMoose
  • perl532Packages.PerlMinimumVersion
  • perl532Packages.PerlTidy
  • perl532Packages.TestMinimumVersion
  • perl532Packages.TestPerlCritic

@SuperSandro2000
Copy link
Member 

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/sdy9qh6q1h9svqdl64zqjcj4342jmcsr-Test-PerlTidy-20200412.tar.gz
source root is Test-PerlTidy-20200412
setting SOURCE_DATE_EPOCH to timestamp 1586674761 of file Test-PerlTidy-20200412/xt/release/trailing-space.t
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
patching ./xt/release/trailing-space.t...
patching ./xt/author/pod-coverage.t...
patching ./xt/author/pod-syntax.t...
patching ./t/exclude_perltidy.t...
patching ./t/exclude_files.t...
patching ./t/is_file_tidy.t...
patching ./t/list_files.t...
patching ./t/perltidy.t...
patching ./t/critic.t...
Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for Test::PerlTidy
Writing MYMETA.yml and MYMETA.json
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
building
Created MYMETA.yml and MYMETA.json
Creating new 'Build' script for 'Test-PerlTidy' version '20200412'
Building Test-PerlTidy
@nix { "action": "setPhase", "phase": "checkPhase" }
running tests
Can't exec "/bin/sh": No such file or directory at /nix/store/38vxlxrvg3yji3jms44qn94lxdysbj5j-perl-5.32.0/lib/perl5/5.32.0/Test/Harness.pm line 306.
t/00-compile.t ........ 
t/00-compile.t ........ 1/1 
                             
t/00-compile.t ........ ok
Can't exec "/bin/sh": No such file or directory at /nix/store/38vxlxrvg3yji3jms44qn94lxdysbj5j-perl-5.32.0/lib/perl5/5.32.0/Test/Harness.pm line 306.
t/critic.t ............ 
                             
t/critic.t ............ skipped: Set $ENV{TEST_AUTHOR} to a true value to run critic tests.
Can't exec "/bin/sh": No such file or directory at /nix/store/38vxlxrvg3yji3jms44qn94lxdysbj5j-perl-5.32.0/lib/perl5/5.32.0/Test/Harness.pm line 306.
t/exclude_files.t ..... 
t/exclude_files.t ..... 1/1 
                             
t/exclude_files.t ..... ok
Can't exec "/bin/sh": No such file or directory at /nix/store/38vxlxrvg3yji3jms44qn94lxdysbj5j-perl-5.32.0/lib/perl5/5.32.0/Test/Harness.pm line 306.
t/exclude_perltidy.t .. 
t/exclude_perltidy.t .. 1/7 
t/exclude_perltidy.t .. 2/7 
                             
t/exclude_perltidy.t .. ok
Can't exec "/bin/sh": No such file or directory at /nix/store/38vxlxrvg3yji3jms44qn94lxdysbj5j-perl-5.32.0/lib/perl5/5.32.0/Test/Harness.pm line 306.
t/is_file_tidy.t ...... 
t/is_file_tidy.t ...... 1/3 
#   Failed test 't/tidy_file.txt'
#   at t/is_file_tidy.t line 17.

t/is_file_tidy.t ...... 3/3 
#   Failed test 'pass perltidy_options perltidyrc named param'
#   at t/is_file_tidy.t line 25.
# Looks like you failed 2 tests of 3.

                             
t/is_file_tidy.t ...... Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/3 subtests 
Can't exec "/bin/sh": No such file or directory at /nix/store/38vxlxrvg3yji3jms44qn94lxdysbj5j-perl-5.32.0/lib/perl5/5.32.0/Test/Harness.pm line 306.
t/list_files.t ........ 
t/list_files.t ........ 1/1 
                             
t/list_files.t ........ ok
Can't exec "/bin/sh": No such file or directory at /nix/store/38vxlxrvg3yji3jms44qn94lxdysbj5j-perl-5.32.0/lib/perl5/5.32.0/Test/Harness.pm line 306.
t/perltidy.t .......... 
t/perltidy.t .......... 1/8 
t/perltidy.t .......... 2/8 
                             
t/perltidy.t .......... ok

Test Summary Report
-------------------
t/is_file_tidy.t    (Wstat: 512 Tests: 3 Failed: 2)
  Failed tests:  1, 3
  Non-zero exit status: 2
Files=7, Tests=21,  4 wallclock secs ( 0.05 usr  0.02 sys +  3.17 cusr  0.92 csys =  4.16 CPU)
Result: FAIL
Failed 1/7 test programs. 2/21 subtests failed.

@zakame
Copy link
Member Author

zakame commented Oct 24, 2020

That's an interesting lot of packages that failed to build, hmmm...

@zakame
Copy link
Member Author

zakame commented Oct 24, 2020

@SuperSandro2000 thanks, perlPackage.TestPerlTidy does need an upgrade too https://metacpan.org/release/SHLOMIF/Test-PerlTidy-20200930 that could probably go ahead in a separate PR?

@zakame
Copy link
Member Author

zakame commented Oct 24, 2020

I'll revise this PR so it goes the other way, as TestPerlTidy requires the newest PerlTidy:

perlPackages.TestPerlTidy: 20200412 -> 20200930

dependencies:
perlPackages.PerlTidy: 20200110 -> 20201001

@zakame zakame changed the title perlPackages.PerlTidy: 20200110 -> 20201001 perlPackages.TestPerlTidy: 20200412 -> 20200930 Oct 24, 2020
@stigtsp
Copy link
Member

stigtsp commented Oct 24, 2020

@GrahamcOfBorg build perlPackages.TestPerlTidy perlPackages.PerlTidy
@GrahamcOfBorg build perldevelPackages.TestPerlTidy perldevelPackages.PerlTidy

@stigtsp stigtsp requested a review from volth October 24, 2020 14:30
@stigtsp
Copy link
Member

stigtsp commented Oct 24, 2020

@zakame Could you split the two bumps into two commits?

@zakame
Copy link
Member Author

zakame commented Oct 24, 2020

@stigtsp done 💪

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 24, 2020 •
edited

Build one darwin:

Result of nixpkgs-review pr 101550 1

27 packages built:
  • freecell-solver
  • perl530Packages.CLIHelpers
  • perl530Packages.DistZillaPluginBundleTestingMania
  • perl530Packages.DistZillaPluginTestCompile
  • perl530Packages.DistZillaPluginTestMinimumVersion
  • perl530Packages.DistZillaPluginTestPerlCritic
  • perl530Packages.PerlCritic
  • perl530Packages.PerlCriticMoose
  • perl530Packages.PerlMinimumVersion
  • perl530Packages.PerlTidy
  • perl530Packages.TaskFreecellSolverTesting
  • perl530Packages.TestMinimumVersion
  • perl530Packages.TestPerlCritic
  • perl530Packages.TestPerlTidy
  • perl532Packages.CLIHelpers
  • perl532Packages.DistZillaPluginBundleTestingMania
  • perl532Packages.DistZillaPluginTestCompile
  • perl532Packages.DistZillaPluginTestMinimumVersion
  • perl532Packages.DistZillaPluginTestPerlCritic
  • perl532Packages.PerlCritic
  • perl532Packages.PerlCriticMoose
  • perl532Packages.PerlMinimumVersion
  • perl532Packages.PerlTidy
  • perl532Packages.TaskFreecellSolverTesting
  • perl532Packages.TestMinimumVersion
  • perl532Packages.TestPerlCritic
  • perl532Packages.TestPerlTidy

@zakame
Copy link
Member Author

zakame commented Oct 24, 2020 •
edited

Build on NixOS:

Result of nixpkgs-review pr 101550 1

30 packages built:
  • freecell-solver
  • gnome3.aisleriot
  • kdeApplications.kpat
  • perl530Packages.CLIHelpers
  • perl530Packages.DistZillaPluginBundleTestingMania
  • perl530Packages.DistZillaPluginTestCompile
  • perl530Packages.DistZillaPluginTestMinimumVersion
  • perl530Packages.DistZillaPluginTestPerlCritic
  • perl530Packages.PerlCritic
  • perl530Packages.PerlCriticMoose
  • perl530Packages.PerlMinimumVersion
  • perl530Packages.PerlTidy
  • perl530Packages.TaskFreecellSolverTesting
  • perl530Packages.TestMinimumVersion
  • perl530Packages.TestPerlCritic
  • perl530Packages.TestPerlTidy
  • perl532Packages.CLIHelpers
  • perl532Packages.DistZillaPluginBundleTestingMania
  • perl532Packages.DistZillaPluginTestCompile
  • perl532Packages.DistZillaPluginTestMinimumVersion
  • perl532Packages.DistZillaPluginTestPerlCritic
  • perlcritic (perl532Packages.PerlCritic)
  • perl532Packages.PerlCriticMoose
  • perl532Packages.PerlMinimumVersion
  • perl532Packages.PerlTidy
  • perl532Packages.TaskFreecellSolverTesting
  • perl532Packages.TestMinimumVersion
  • perl532Packages.TestPerlCritic
  • perl532Packages.TestPerlTidy
  • pysolfc

stigtsp
stigtsp approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Result of nixpkgs-review pr 101550 1

30 packages built:
  • freecell-solver
  • gnome3.aisleriot
  • kdeApplications.kpat
  • perl530Packages.CLIHelpers
  • perl530Packages.DistZillaPluginBundleTestingMania
  • perl530Packages.DistZillaPluginTestCompile
  • perl530Packages.DistZillaPluginTestMinimumVersion
  • perl530Packages.DistZillaPluginTestPerlCritic
  • perl530Packages.PerlCritic
  • perl530Packages.PerlCriticMoose
  • perl530Packages.PerlMinimumVersion
  • perl530Packages.PerlTidy
  • perl530Packages.TaskFreecellSolverTesting
  • perl530Packages.TestMinimumVersion
  • perl530Packages.TestPerlCritic
  • perl530Packages.TestPerlTidy
  • perl532Packages.CLIHelpers
  • perl532Packages.DistZillaPluginBundleTestingMania
  • perl532Packages.DistZillaPluginTestCompile
  • perl532Packages.DistZillaPluginTestMinimumVersion
  • perl532Packages.DistZillaPluginTestPerlCritic
  • perlcritic (perl532Packages.PerlCritic)
  • perl532Packages.PerlCriticMoose
  • perl532Packages.PerlMinimumVersion
  • perl532Packages.PerlTidy
  • perl532Packages.TaskFreecellSolverTesting
  • perl532Packages.TestMinimumVersion
  • perl532Packages.TestPerlCritic
  • perl532Packages.TestPerlTidy
  • pysolfc

@stigtsp
Copy link
Member

stigtsp commented Oct 24, 2020

Built OK on darwin x64 on my mac
@aanderse can you trigger a build to test darwin on Ofborg?

@aanderse
Copy link
Member

@GrahamcOfBorg build perlPackages.TestPerlTidy

No problem. Is the bot working on darwinagain?

@stigtsp
Copy link
Member

stigtsp commented Oct 24, 2020

No problem. Is the bot working on darwinagain?

Thx! Hm, don't seem like it.

@stigtsp stigtsp merged commit ec352cc into NixOS:master Oct 24, 2020
@zakame
Copy link
Member Author

zakame commented Oct 24, 2020

Thank you everyone! 👍

@zakame zakame deleted the updates/perl-PerlTidy branch October 24, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zakame @SuperSandro2000 @stigtsp @aanderse