Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bacula: fix build on darwin #101526

Merged
merged 1 commit into from Oct 25, 2020
Merged

bacula: fix build on darwin #101526

merged 1 commit into from Oct 25, 2020

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Oct 24, 2020

Motivation for this change

ZHF 20.09 #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 24, 2020
veprbl
veprbl approved these changes Oct 25, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on x86_64-darwin

@veprbl veprbl merged commit 4e88622 into NixOS:master Oct 25, 2020
veprbl pushed a commit that referenced this pull request Oct 25, 2020
@r-burns @veprbl
bacula: fix build on darwin (#101526)
997f7a3 
(cherry picked from commit 4e88622)
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 25, 2020
@r-burns r-burns deleted the bacula branch October 25, 2020 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@proteansec proteansec Awaiting requested review from proteansec

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-burns @veprbl @SuperSandro2000