Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn2nix: expose yarnPostBuild #101521

Merged
merged 1 commit into from Jun 9, 2021
Merged

yarn2nix: expose yarnPostBuild #101521

merged 1 commit into from Jun 9, 2021
+2 −0

Conversation

egasimus
Copy link
Contributor

@egasimus egasimus commented Oct 24, 2020 •
edited

Motivation for this change

The way I see it, there's no point in the argument being there if it can't be used.
Right now, its lack prevents a workaround for an issue I can't wrap my head around - first encountered here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Please update the commit message to yarn2nix: expose yarnPostBuild or similar. Starting with yarn2nix is the important part.

@egasimus
yarn2nix: expose yarnPostBuild
4ef1e5b 
The way I see it, there's no point in the argument being there if it can't be used.
Right now its lack currently prevents a workaround for an issue I can't wrap my head around - first encountered [here](https://logs.nix.samueldr.com/nixos-dev/2019-08-28#2532857;).
@egasimus
Copy link
Contributor Author

egasimus commented Dec 8, 2020

@SuperSandro2000 Fixed. Thanks for reviewing!

@SuperSandro2000 SuperSandro2000 changed the title Expose mkYarnModules' postBuild as yarnPostBuild yarn2nix: expose yarnPostBuild Dec 9, 2020
@stale
Copy link

stale bot commented Jun 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021
@egasimus
Copy link
Contributor Author

egasimus commented Jun 7, 2021

@SuperSandro2000 do you know what needs to be done to get this into mainline?

@SuperSandro2000
Copy link
Member

@ofborg eval

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 8, 2021
@SuperSandro2000 SuperSandro2000 merged commit 476f69b into NixOS:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@egasimus @SuperSandro2000