Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.composer2: 2.0.0RC-1 -> 2.0.0 #101540

Merged
merged 1 commit into from Oct 24, 2020
Merged

phpPackages.composer2: 2.0.0RC-1 -> 2.0.0 #101540

merged 1 commit into from Oct 24, 2020

Conversation

shyim
Copy link
Member

@shyim shyim commented Oct 24, 2020 •
edited

Motivation for this change

https://blog.packagist.com/composer-2-0-is-now-available/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@shyim shyim requested a review from etu October 24, 2020 11:01
@etu etu merged commit a6d56b9 into NixOS:master Oct 24, 2020
@shyim shyim deleted the patch-2 branch October 24, 2020 12:11
@aanderse
Copy link
Member

@etu since this is a leaf package should we add composer2 to the 20.09 stable branch? It seems like it would be of value.

@etu
Copy link
Contributor

etu commented Oct 27, 2020

@aanderse I'm fine with that, you can backport it if you want :)

@aanderse
Copy link
Member

Thanks @etu, I'll take care of that tonight!

@aanderse aanderse mentioned this pull request Oct 28, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

@aanderse aanderse Awaiting requested review from aanderse aanderse is a code owner

@globin globin Awaiting requested review from globin globin is a code owner

@talyz talyz Awaiting requested review from talyz talyz is a code owner

@Ma27 Ma27 Awaiting requested review from Ma27 Ma27 is a code owner

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shyim @aanderse @etu