nixos-generate-config: Change how auto-generated swap files are detected #101529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
nixos-generate-config.plcurrently does not have enough information to intelligently decide which swap devices should be automatically configured and which should not. The current logic is fairly basic, and results in edge cases: #86353This patch makes NixOS record at rebuild time which swap devices were manually configured, so the script doesn't have to guess later.
Looking for feedback. This patch does work, but is it the best solution to the problem? Can anyone think of a better one?
The /etc/* file is just a placeholder. The file probably belongs somewhere else.