Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sbcl: 2.0.0 -> 2.0.8; add 2.0.9; lispPackages: regenerate #101544

Merged
merged 12 commits into from Oct 24, 2020
Merged

sbcl: 2.0.0 -> 2.0.8; add 2.0.9; lispPackages: regenerate #101544

merged 12 commits into from Oct 24, 2020

Conversation

7c6f434c
Copy link
Member

Motivation for this change

#94913 and stuff getting stale

README on updates missing some useful pointers

unblocks #92763 I guess

Will self-merge once checks pass

Things done

Entire lispPackages build, no sbcl_2_0_2 references in Nixpkgs

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c @omasanori
pkgs/development/lisp-modules/README.txt : typo fix
c4c06f5 
Co-authored-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@7c6f434c
Copy link
Member Author

@ofborg build lispPackages lispPackages.query-fs

@7c6f434c 7c6f434c merged commit 18a170f into NixOS:master Oct 24, 2020
@7c6f434c 7c6f434c mentioned this pull request Oct 24, 2020
Closed
10 tasks
@purcell
Copy link
Member

purcell commented Oct 25, 2020

Nice! Was there a compatibility issue with bumping directly to 2.0.9?

@omasanori
Copy link
Contributor

@purcell Zach Beane Common Lisp – New SBCL 2.0.9 behavior breaks some stuff warns such issue, so @7c6f434c and I did not make 2.0.9 as the default one.

@purcell
Copy link
Member

purcell commented Oct 25, 2020

Ah, makes sense! I thought it might be something like that. Great work!

@7c6f434c
Copy link
Member Author

@purcell, it was kind of the same the previous time with 2.0.0 vs 2.0.1 too, SBCL does an apriori very reasonable thing but there are fragile and useful packages that need a bit of time to adjust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omasanori omasanori omasanori left review comments

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@7c6f434c @purcell @omasanori