Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotify-cli-linux: init at 1.6.0 #101547

Merged
merged 2 commits into from Nov 17, 2020
Merged

spotify-cli-linux: init at 1.6.0 #101547

merged 2 commits into from Nov 17, 2020

Conversation

kmein
Copy link
Member

@kmein kmein commented Oct 24, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101547 1

1 package failed to build:
  • python27Packages.spotify-cli-linux
5 packages built:
  • python27Packages.lyricwikia
  • python37Packages.lyricwikia
  • python37Packages.spotify-cli-linux
  • python38Packages.lyricwikia
  • python38Packages.spotify-cli-linux

FRidh
FRidh requested changes Oct 24, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the tests disabled? Include a comment in the expression explaining why the tests are disabled.

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@kmein kmein changed the title python3Packages.{spotify-cli-linux,lyricwikia}: init spotify-cli-linux: init at 1.6.0 Oct 24, 2020
@kmein
Copy link
Member Author

kmein commented Oct 24, 2020 •
edited

Why are the tests disabled? Include a comment in the expression explaining why the tests are disabled.

@FRidh I'm getting this error: nix_run_setup: error: unrecognized arguments: test

@SuperSandro2000
Copy link
Member

Upstream only has linting and formatting checks but no actual code tests.

@berbiche
Copy link
Member

There is a dbus-send call in the tool:
https://github.com/pwittchen/spotify-cli-linux/blob/b94bad8f4519c249909c7c9a176adfe2f789e2ca/spotifycli/spotifycli.py#L196-L200

I think it will need a substituteInPlace to have the right binary instead of using whatever dbus-send is available in the user environment.

@kmein kmein force-pushed the feature/spotify-cli-linux branch 2 times, most recently from 5197ddb to eadbcd4 Compare October 25, 2020 09:24
@kmein kmein requested a review from FRidh October 25, 2020 09:24
@Lassulus Lassulus merged commit d93584c into NixOS:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@jonringer jonringer Awaiting requested review from jonringer

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kmein @SuperSandro2000 @berbiche @sikmir @FRidh @Lassulus