Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimv: init at unstable-2019-10-31 #101548

Merged
merged 1 commit into from Oct 27, 2020
Merged

vimv: init at unstable-2019-10-31 #101548

merged 1 commit into from Oct 27, 2020

Conversation

kmein
Copy link
Member

@kmein kmein commented Oct 24, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kmein kmein requested a review from Lassulus October 25, 2020 13:23
@kmein kmein force-pushed the feature/vimv branch 2 times, most recently from 799d084 to 569a2b9 Compare October 25, 2020 14:32
@kmein kmein requested a review from Lassulus October 25, 2020 15:05
@kmein kmein requested a review from Lassulus October 25, 2020 18:13
@kmein kmein changed the title vimv: init vimv: init at unstable-2019-10-31 Oct 25, 2020
@Lassulus Lassulus merged commit 6a62663 into NixOS:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmein @Lassulus