Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yle-dl: 2.31 -> 20200807 #100191

Merged
merged 4 commits into from Oct 28, 2020
Merged

yle-dl: 2.31 -> 20200807 #100191

merged 4 commits into from Oct 28, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

https://r.ryantm.com/log/2020-10-09.log

Things done

Updated to latest version and fixed tests when enabled.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dezgeg October 11, 2020 00:33
@sikmir
Copy link
Member

sikmir commented Oct 12, 2020

@SuperSandro2000 Please, update license to licenses.gpl3Plus, since licenses.gpl3 is deprecated (https://discourse.nixos.org/t/lib-licenses-gpl3-co-are-now-deprecated/8206/4).
See https://github.com/aajanki/yle-dl/blob/3100fa5f4f82583d092e580930b84cd3214860f1/setup.py#L56:
'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 Please, update license to licenses.gpl3Plus, since licenses.gpl3 is deprecated (discourse.nixos.org/t/lib-licenses-gpl3-co-are-now-deprecated/8206/4).
See aajanki/yle-dl@3100fa5/setup.py#L56:
'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',

@sikmir Changed that. Thanks for the notice.

@sikmir
Copy link
Member

sikmir commented Oct 27, 2020

20201022 is out.

@SuperSandro2000
Copy link
Member Author

20201022 is out.

Updated. Thanks for the notice!

sikmir
sikmir requested changes Oct 27, 2020
View reviewed changes
pkgs/tools/misc/yle-dl/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 @sikmir
yle-dl: enable on unix
100ddc3 
Thanks @sikmir

Co-authored-by: Nikolay Korotkiy <sikmir@gmail.com>
@sikmir
Copy link
Member

sikmir commented Oct 28, 2020

yle-dl moved to python3 #101964

@jonringer
Copy link
Contributor

I was wondering why this looked so familiar #67656

jonringer
jonringer approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/100191
1 package built:
yle-dl

@jonringer jonringer merged commit 99bf27c into NixOS:master Oct 28, 2020
@SuperSandro2000 SuperSandro2000 deleted the yle-dl branch November 1, 2020 14:37
@jonringer jonringer mentioned this pull request Nov 1, 2020
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir approved these changes

@jonringer jonringer jonringer approved these changes

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @sikmir @jonringer