Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] partimage: fix build #100170

Merged
merged 1 commit into from Oct 11, 2020
Merged

[20.09] partimage: fix build #100170

merged 1 commit into from Oct 11, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 10, 2020

Motivation for this change

ZHF: #97479

Backport of #99052

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
partimage: fix build
fa25e1b 
the move to glibc 2.30 broke the build of this old package, fortunately
debian have a patch to fix it

(cherry picked from commit 5983c41)
@risicle risicle changed the title partimage: fix build [20.09] partimage: fix build Oct 10, 2020
@jonringer
Copy link
Contributor

wow, this package is fantastically unmaintained. I think it should be considered for removal.

jonringer
jonringer approved these changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 100170 1

1 package built:
  • partimage

@jonringer jonringer merged commit 460db36 into NixOS:release-20.09 Oct 11, 2020
@risicle
Copy link
Contributor Author

risicle commented Oct 11, 2020

Perhaps, but it's extremely useful and can be a complete life saver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer