Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bunch of updates #100193

Merged
merged 10 commits into from Oct 12, 2020
Merged

A bunch of updates #100193

merged 10 commits into from Oct 12, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 11, 2020 •
edited

A big chunk of updates

  • 3mux: 0.3.0 -> 1.0.1
  • a2jmidid: 8 -> 9
  • stella: 6.2.1 -> 6.3
  • pari: 2.11.3 -> 2.11.4
  • gp2c: 0.0.11pl3 -> 0.0.11pl4
  • guile-reader: 0.6.2 -> 0.6.3
  • comic-neue: 2.5 -> 2.51
  • kid3: 3.8.3 -> 3.8.4
  • luakit: 2.2 -> 2.2.1
  • icewm: 1.7.0 -> 1.8.3
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

Generally looks fine

@ofborg ofborg bot requested a review from 7c6f434c October 11, 2020 21:28
@aaronjanse
Copy link
Member

3mux 1.0.1 is a pre-release, not meant to be packaged yet. Some changes are upcoming that will significantly improve 3mux performance and reliability.

In the future I'll avoid tagging pre-releases, since they seem to be picked up by a lot of package management machinery :-)

@aaronjanse
Copy link
Member

Regardless, thank you @AndersonTorres for all the work done in this PR! I don't know enough about the other packages to review them, but I appreciate your work

@AndersonTorres
Copy link
Member Author

@aaronjanse well, I just followed Repology. And the jump from 0.3 to 1.0 looked high enough to not be ignored. Anyway, many thanks to tell me!

@AndersonTorres
Copy link
Member Author

Well, there are only two packages from other people, namely 3mux and a2jmidid. The maintainer of a2jmidid, @goibhniu , looks stalled. I will merge it, then.

@ofborg ofborg bot requested a review from 7c6f434c October 12, 2020 07:19
timokau
timokau approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally would have left out the re-wrapping of documentation lines and I disagree that the repo = pname changes are an improvement, but there's no real consensus there and it's not important.

Looks good to me. Thanks!

@AndersonTorres AndersonTorres changed the title A stream of updates A bunch of updates Oct 12, 2020
@AndersonTorres AndersonTorres merged commit e61c9d1 into NixOS:master Oct 12, 2020
@AndersonTorres AndersonTorres deleted the big-upload branch October 12, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@aaronjanse aaronjanse Awaiting requested review from aaronjanse

@kalbasit kalbasit Awaiting requested review from kalbasit

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndersonTorres @7c6f434c @aaronjanse @timokau