Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] bazel_1: fix build on darwin #100180

Merged
merged 1 commit into from Oct 13, 2020
Merged

[20.09] bazel_1: fix build on darwin #100180

merged 1 commit into from Oct 13, 2020

Conversation

tricktron
Copy link
Member

@tricktron tricktron commented Oct 10, 2020 •
edited

Motivation for this change

Backport of #100012
ZHF: #97479
cc: @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tricktron
bazel_1: fix build on darwin
ea5505f 
Use clang_8 instead of clang_7 on darwin to fix thread_local storage error.

(cherry picked from commit f7aafe6)
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 10, 2020
@ofborg ofborg bot requested a review from mboes October 10, 2020 21:37
@domenkozar domenkozar merged commit 70eb779 into NixOS:release-20.09 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@mboes mboes Awaiting requested review from mboes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tricktron @domenkozar