This latest version add a patch that fixes debugging a specific test.

At this point, this extension as been quite extensively tested on projects of significant size. It works impressively well.

@SuperSandro2000: Thanks for the review. Re-based on top of latest which fixes the conflict, applied the suggested changes and re-tested. Everything still works fine.

Result of nixpkgs-review pr 100181 run on x86_64-linux 1

@SuperSandro2000: Is anything wrong with nixpkgs-review pr 100181's output? Running the command locally does not fail.

@SuperSandro2000: Is anything wrong with nixpkgs-review pr 100181's output? Running the command locally does not fail.

Nope but I am not sure if this is all packaged correctly and it is a very big diff so I decided to not merge it.

Will it eventually get merged or really there'll be no way of using the c# ext in vscode on nixos?

@rdk31: Would like for this to go forward. However, I wasn't told what was missing / wrong.

@ofborg eval

@SuperSandro2000: Didn't you misstype eval?

@SuperSandro2000: Didn't you misstype eval?

Yeah, fixed.

IMO we need some utility functions to automate some of this across a few packages.

Inside the vsix there is a package.json with a runtimeDependencies key with platform specific runtime dependencies. That is how VSCode finds and downloads runtime dependencies, in this case, OmniSharp, .NET Debugger, and Razor.

An idiomatic solution would be something that lets us do the following:

{vscode-utils, omnisharp, dotnet-debugger, razor-language-server}:
vscode-utils.buildVscodeMarketplaceExtension {
  mktplcRef = {
    name = "csharp";
    publisher = "ms-dotnettools";
    version = "1.23.2";
    sha256 = "0ydaiy8jfd1bj50bqiaz5wbl7r6qwmbz9b29bydimq0rdjgapaar";
  };
  runtimeDependencies = {
    "Omnisharp" = omnisharp;
    "Debugger" = dotnet-debugger;
    "Razor" = razor-language-server;
  }
}

...and buildVscodeMarketplaceExtension just does the magic of mapping the dependencies in package.json to the supplied runtimeDependencies,

@SuperSandro2000: Fixes as requested.

@jbalme: Seems like good idea worth working upon to improve the vscode extension framework for nix. IMO: it seems indeed related to this issue but out of scope. It might be worth opening a separate Issue / PR with a reference to this issue (and other) as examples of what would be improved. This would allow not to delay this issue and continue working on improving the whole set of extensions.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 100181 run on x86_64-linux 1

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

   |
25 |     buildInputs = [ unzip ] ++ buildInputs;
   |     ^

@SuperSandro2000: The above buildInput issue with automated check is caused by pkgs/misc/vscode-extensions/vscode-utils.nix which is not in our current set of files. Should we fix this as part of this PR or leave it for a separate PR?

Should we fix this as part of this PR or leave it for a separate PR?

Separate PR please.