Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

halide: 2019.08.27 -> 10.0.0, enable on aarch64-linux #100202

Merged
merged 2 commits into from Nov 3, 2020
Merged

halide: 2019.08.27 -> 10.0.0, enable on aarch64-linux #100202

merged 2 commits into from Nov 3, 2020

Conversation

OPNA2608
Copy link
Contributor

Motivation for this change

Bumped version, cleaned up the derivation abit & ran it through nixpkgs-fmt. Needed it for another project on aarch64-linux and it successfully compiled on it, so I also enabled that platform in the meta section.

I have no clue about that blas stuff so I tried not to touch it, the patch seemed redundant and the CMake build now has an install target.

CC @ck3d

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions - aarch64 pmOS on my phone
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ck3d October 11, 2020 03:53
ck3d
ck3d approved these changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@ck3d ck3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could build Halide and some simle projects.

@OPNA2608 OPNA2608 mentioned this pull request Oct 20, 2020
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/276

@kevincox kevincox merged commit e031671 into NixOS:master Nov 3, 2020
@OPNA2608 OPNA2608 deleted the update/halide-10.0.0 branch September 27, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ck3d ck3d ck3d approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OPNA2608 @nixos-discourse @ck3d @kevincox