Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-play-music-desktop-player: copy icons #100186

Closed
wants to merge 2 commits into from
Closed

google-play-music-desktop-player: copy icons #100186

wants to merge 2 commits into from

Conversation

AlexGoico
Copy link

@AlexGoico AlexGoico commented Oct 10, 2020 •
edited

Icons need to be copied over to correct directories in order for share's .desktop to function.

Motivation for this change

Issue: #98139
Unable to get Google play music to launch from KDE without a terminal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AlexGoico
google-play-music-desktop-player: copy icons
3491c1c 
Icons need to be copied over to correct directories in order for
share's .desktop to function.
@AlexGoico
google-play-music-desktop-player: add imagemagick
cd0d9c4 
Add imagemagick for convert in previous commit
@ofborg ofborg bot requested a review from SuprDewd October 10, 2020 23:49
SuprDewd
SuprDewd approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@SuprDewd SuprDewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 100186 run on x86_64-linux 1

1 package built:
  • google-play-music-desktop-player

SuperSandro2000
SuperSandro2000 reviewed Nov 27, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits.

@dotlambda
Copy link
Member

Closing this as Google Play Music was discontinued.

@dotlambda dotlambda closed this Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@SuprDewd SuprDewd SuprDewd approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AlexGoico @SuperSandro2000 @dotlambda @SuprDewd @Janik-Haag