Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sbt: apply autoPatchelfHook only in Linux #100212

Merged
merged 1 commit into from Oct 11, 2020
Merged

sbt: apply autoPatchelfHook only in Linux #100212

merged 1 commit into from Oct 11, 2020

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Oct 11, 2020 •
edited

Motivation for this change

Fixes #100211

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@regadas
Copy link
Contributor Author

regadas commented Oct 11, 2020

/cc @NeQuissimus PTAL. Thanks

@ofborg ofborg bot requested a review from NeQuissimus October 11, 2020 07:15
@gebner
Copy link
Member

gebner commented Oct 11, 2020

Uggh, I didn't know the sbt distribution contains pre-built binaries. I'm surprised this doesn't break on aarch64 (we install the x86_64 one).

@gebner gebner merged commit b5f4460 into NixOS:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SBT 1.4.0 fails on darwin
2 participants
@regadas @gebner