Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] pythonPackages.xarray, pythonPackages.arviz: bump/fix build #100237

Merged
merged 2 commits into from Oct 11, 2020
Merged

[20.09] pythonPackages.xarray, pythonPackages.arviz: bump/fix build #100237

merged 2 commits into from Oct 11, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 11, 2020 •
edited

Motivation for this change

ZHF: #97479

This is a combined backport of #93412 and #99500. #93412 simply needed to satisfy the bumped arviz's dependencies.

Only reverse dependency build failures for me are already failing on release-20.09. (The test suite for datashader has never completed on my machine)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor Author

risicle commented Oct 11, 2020

(still building on macos...)

@risicle
Copy link
Contributor Author

risicle commented Oct 11, 2020

@ofborg build python37Packages.arviz

@risicle
Copy link
Contributor Author

risicle commented Oct 11, 2020

Yup, all macos failures are pre-existing for me.

@risicle risicle merged commit 2966772 into NixOS:release-20.09 Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

@jonringer jonringer Awaiting requested review from jonringer jonringer is a code owner

@OmnipotentEntity OmnipotentEntity Awaiting requested review from OmnipotentEntity

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @FRidh