Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ngscopeclient/scopehal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 929fa824f1cc
Choose a base ref
...
head repository: ngscopeclient/scopehal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1b6bd4682dd5
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 11, 2020

  1. FlowGraphNode: fixed bug where calling SetInput() with the current in…

    …put could free a filter we were still using
    azonenberg committed Oct 11, 2020
    Copy the full SHA
    1b6bd46 View commit details
Showing with 4 additions and 0 deletions.
  1. +4 −0 scopehal/FlowGraphNode.cpp
4 changes: 4 additions & 0 deletions scopehal/FlowGraphNode.cpp
Original file line number Diff line number Diff line change
@@ -92,6 +92,10 @@ void FlowGraphNode::SetInput(size_t i, StreamDescriptor stream, bool force)
{
if(i < m_signalNames.size())
{
//Calling SetInput with the current input is a legal no-op
if(stream == m_inputs[i])
return;

if(stream.m_channel == NULL) //NULL is always legal
{
m_inputs[i] = StreamDescriptor(NULL, 0);