sc-controller: fix broken svg icons #100254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Oct 11, 2020
| @@ -34,6 +35,7 @@ buildPythonApplication rec { | |||
|
|
|||
| preFixup = '' | |||
| gappsWrapperArgs+=(--prefix LD_LIBRARY_PATH : "$LD_LIBRARY_PATH") | |||
| gappsWrapperArgs+=(--set GDK_PIXBUF_MODULE_FILE ${librsvg}/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache) | |||
There was a problem hiding this comment.
This should be the default. Maybe strictDeps are interfering like in #56943.
There was a problem hiding this comment.
I found this commit 6c5983a to be the cause while bisecting, maybe it means something to you.
There was a problem hiding this comment.
Looks like you're right: settings strictDeps is working.
The gdk-pixbuf module exposed by librsvg wasn't detected due to strictDeps being enabled by default in python packages.
rnhmjoj
force-pushed
the
sc-controller
branch
from
e7c52a7
to
65cbea4
Compare
|
I'm going ahead and merge this early because the software is broken in release-20.09. |
|
Backport ca3477e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See #98116
Things done
nix path-info -Sbefore and after)cc: @orivej @timjrd