Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] Pantheon stuff #100224

Merged
merged 4 commits into from Oct 12, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Version of https://github.com/NixOS/nixpkgs/pull/100116/commits for 20.09 with backports.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

Reminder to self to drop fb87171 and to merge it in #100225 later

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: pantheon The Pantheon desktop environment 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels Oct 11, 2020
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seem to solve the issue

Because gnome-session now uses 'enabled' systemd session we have
to make this use --builtin [0]

[0]: elementary/session-settings@fa15cbd

(cherry picked from commit 17d7060)
These are now generated to be patched as a part of the elementary-session-settings
build.

(cherry picked from commit a4572eb)
@worldofpeace worldofpeace merged commit 2324dce into NixOS:release-20.09 Oct 12, 2020
Pantheon automation moved this from In progress to Done Oct 12, 2020
@worldofpeace worldofpeace deleted the pantheon-stuff-20.09 branch October 12, 2020 22:50
@ofborg ofborg bot removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label Oct 12, 2020
@bobby285271 bobby285271 mentioned this pull request Nov 25, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pantheon
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants