Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: update compile flags #100251

Merged
merged 1 commit into from Oct 12, 2020
Merged

dnsdist: update compile flags #100251

merged 1 commit into from Oct 12, 2020

Conversation

aanderse
Copy link
Member

Motivation for this change

The configure flags have been renamed. See https://dnsdist.org/upgrade_guide.html#x-to-1-4-0.

If this is seen as a security regression (though likely it isn't) then a backport may be worthwhile. Someone who is familiar with the software would need to determine if the lack of libsodium is a serious concern.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dasJ
dasJ approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@dasJ dasJ left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I switched to a proper DNS setup, do you want to replace me as maintainer? I'm not using this in production anymore

@aanderse
Copy link
Member Author

I have never used this software so I'm unable to.

@aanderse aanderse merged commit 176f45c into NixOS:master Oct 12, 2020
@aanderse aanderse deleted the dnsdist-flags branch October 12, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@dasJ dasJ dasJ approved these changes

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @rnhmjoj @dasJ