Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.22.0 -> 1.22.1 #102177

Merged
merged 1 commit into from Oct 31, 2020
Merged

matrix-synapse: 1.22.0 -> 1.22.1 #102177

merged 1 commit into from Oct 31, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 30, 2020

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.22.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 30, 2020
@ofborg ofborg bot requested a review from pacien October 30, 2020 18:54
fadenb
fadenb approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@fadenb fadenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the same change locally for a few hours now. Seems OK.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 30, 2020 •
edited

Result of nixpkgs-review pr 102177 run on x86_64-darwin 1

1 package failed to build:
  • matrix-synapse

Edit: The package rebuilds locally just fine. I don't quite understand the failure.

@Ma27 Ma27 merged commit b18d189 into NixOS:master Oct 31, 2020
@Ma27 Ma27 deleted the bump-matrix-synapse branch October 31, 2020 17:47
@Ma27
Copy link
Member Author

Ma27 commented Oct 31, 2020

20.03: 050b006
20.09: 190e162

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadenb fadenb fadenb approved these changes

@Ralith Ralith Awaiting requested review from Ralith

@mweinelt mweinelt Awaiting requested review from mweinelt

@Ekleog Ekleog Awaiting requested review from Ekleog

@mguentner mguentner Awaiting requested review from mguentner

@ajs124 ajs124 Awaiting requested review from ajs124

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@pacien pacien Awaiting requested review from pacien

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @SuperSandro2000 @fadenb