Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-shell-extension-pop-shell: init at 1.0.0 #102150

Closed
wants to merge 1 commit into from
Closed

gnome-shell-extension-pop-shell: init at 1.0.0 #102150

wants to merge 1 commit into from

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Oct 30, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Oct 30, 2020
worldofpeace
worldofpeace suggested changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should have init at not @

@worldofpeace worldofpeace requested a review from a team October 30, 2020 21:39
@Synthetica9 Synthetica9 changed the title gnome-shell-extension-pop-shell: init @ 1.0.0 gnome-shell-extension-pop-shell: init at 1.0.0 Nov 1, 2020
@Synthetica9
Copy link
Member Author

Commit message should have init at not @

The commit message already had that, it was only the pr title that didn't. Changed it

@buckley310 buckley310 mentioned this pull request Nov 20, 2020
Closed
10 tasks
SuperSandro2000
SuperSandro2000 requested changes Nov 25, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please squash the commits together?

SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the eval error.

pkgs/desktops/gnome-3/extensions/pop-shell/default.nix Outdated Show resolved Hide resolved
@Synthetica9
Copy link
Member Author

@grahamc Wait, there was already a PR. Anyways; these are the extensions they use. I updated them to the latest version but can't test that atm since I don't have a Gnome setup (same reason I removed myself as maintainer).

SuperSandro2000
SuperSandro2000 reviewed Mar 31, 2021
View reviewed changes
pkgs/desktops/gnome-3/extensions/pop-shell/default.nix
Comment on lines +29 to +30
license = licenses.gpl3;
maintainers = with maintainers; [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpl3Only or gpl3Plus? Maintainer needs to be set.

benneti
benneti reviewed Mar 31, 2021
View reviewed changes
Copy link
Contributor

@benneti benneti left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't a patch like
https://github.com/NixOS/nixpkgs/blob/b4f8e0120472735bd0d056f1e1c9c2a14408bdff/pkgs/desktops/gnome-3/extensions/pop-os-shell/fix-gjs.patch
necessary?

pkgs/desktops/gnome-3/extensions/pop-shell/default.nix

postInstall = ''
mv $out/usr/* $out
rmdir $out/usr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you add makeFlags = [ "XDG_DATA_HOME=$(out)/share" ]; you don't need to move the files

@Icy-Thought Icy-Thought mentioned this pull request Jun 23, 2021
Closed
@ratsclub ratsclub mentioned this pull request Jul 18, 2021
Closed
@stale
Copy link

stale bot commented Oct 1, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 1, 2021
@Enzime Enzime mentioned this pull request Nov 3, 2021
Closed
12 tasks
@genofire genofire mentioned this pull request Nov 26, 2021
Merged
13 tasks
@genofire
Copy link
Contributor

genofire commented Dec 2, 2021

Solved in #147542 - i believe we could close this PR now.
Maybe you add yourself to maintainers ;)

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 2, 2021
@Synthetica9
Copy link
Member Author

Solved in #147542 - i believe we could close this PR now. Maybe you add yourself to maintainers ;)

Great to hear, but I don't currently use Gnome. Thanks for picking this up though!

@Synthetica9 Synthetica9 closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@benneti benneti benneti left review comments

@worldofpeace worldofpeace worldofpeace requested changes

@luc65r luc65r luc65r requested changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Synthetica9 @genofire @SuperSandro2000 @benneti @worldofpeace @luc65r