Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ptouch-print: init at 1.4.3 #102155

Merged
merged 1 commit into from Dec 28, 2020
Merged

ptouch-print: init at 1.4.3 #102155

merged 1 commit into from Dec 28, 2020

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

#101712

Things done

Packaged ptouch-print release 1.4.3

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

luc65r
luc65r suggested changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@luc65r luc65r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need lib in the arguments

- { lib
- , stdenv
+ { stdenv
- meta = with lib; {
+ meta = with stdenv.lib; {

This makes it easier to add other maintainers later

- maintainers = [ maintainers.shamilton ];
+ maintainers = with maintainers; [ shamilton ];

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102155 run on x86_64-linux 1

1 package built:
  • ptouch-print

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102155 run on x86_64-linux 1

1 package built:
  • ptouch-print

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102155 run on x86_64-linux 1

1 package built:
  • ptouch-print

@SuperSandro2000 SuperSandro2000 merged commit a08cfe7 into NixOS:master Dec 28, 2020
@grahamc
Copy link
Member

grahamc commented Dec 28, 2021

It looks like this homepage and source has fallen off the internet.

@tjkirch
Copy link
Contributor

tjkirch commented Mar 28, 2024

It looks like this homepage and source has fallen off the internet.

See #197981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@luc65r luc65r luc65r requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SCOTT-HAMILTON @SuperSandro2000 @grahamc @tjkirch @luc65r