Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gsoap: 2.8.53 -> 2.8.108 #102149

Merged
merged 1 commit into from Nov 3, 2020
Merged

gsoap: 2.8.53 -> 2.8.108 #102149

merged 1 commit into from Nov 3, 2020

Conversation

braunse
Copy link
Contributor

@braunse braunse commented Oct 30, 2020 •
edited

Motivation for this change

Fixes CVE-2019-7659

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@braunse
Copy link
Contributor Author

braunse commented Oct 30, 2020

Closure size comparison:

/nix/store/skba5i2wyx5cwph2j8b2ba76kzdcqfml-gsoap-2.8.53           55075592 # before
/nix/store/rxrf4z3qr0yks087h71qficjzyni86vf-gsoap-2.8.108          55571808 # after

@braunse
Copy link
Contributor Author

braunse commented Oct 30, 2020

Result of nixpkgs-review pr 102149 1

1 package built:
  • gsoap

@ofborg ofborg bot requested a review from bjornfor October 30, 2020 13:07
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102149 run on x86_64-darwin 1

stigtsp
stigtsp approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102149 1

1 package built:
  • gsoap

@stigtsp stigtsp merged commit 25eb2e3 into NixOS:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@braunse @SuperSandro2000 @stigtsp