Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

versus: init at 1.0 #102147

Merged
merged 1 commit into from Nov 24, 2020
Merged

versus: init at 1.0 #102147

merged 1 commit into from Nov 24, 2020

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Oct 30, 2020

Motivation for this change

versus is a handy tool for API benchmarking

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102147 run on x86_64-darwin 1

1 package built:
  • versus

@ofborg ofborg bot requested a review from kalbasit October 30, 2020 14:57
@mmahut
Copy link
Member Author

mmahut commented Nov 1, 2020

@SuperSandro2000 what do you think? :)

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102147 run on x86_64-darwin 1

1 package built:
  • versus

@mmahut
Copy link
Member Author

mmahut commented Nov 5, 2020

@GrahamcOfBorg build versus

1 similar comment
@mmahut
Copy link
Member Author

mmahut commented Nov 9, 2020

@GrahamcOfBorg build versus

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102147 run on x86_64-linux 1

1 package built:
  • versus

@SuperSandro2000 SuperSandro2000 merged commit e4490f9 into NixOS:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmahut @SuperSandro2000