Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agda-categories: fix version #102161

Closed
wants to merge 1 commit into from
Closed

agda-categories: fix version #102161

wants to merge 1 commit into from

Conversation

alexarice
Copy link
Contributor

Motivation for this change

Seems agda-categories has changed its version from v0.1.4 to v0.14?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@turion

luc65r
luc65r reviewed Oct 30, 2020
View reviewed changes
pkgs/development/libraries/agda/agda-categories/default.nix
pname = "agda-categories";

src = fetchFromGitHub {
owner = "agda";
repo = "agda-categories";
rev = "v${version}";
sha256 = "0n6y9xarqhj95i4h56klx10gy0fyckxbfwgiissfknpfq6l0m7r6";
hash = "sha256-Jp8KqMHu2um0jvFxt/pk3gH/QOh0mgJJLElCnFVP3lg=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing the hash format?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't work out how to get the old format with nixUnstable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-hash --type sha256 --flat --base32 <(echo "sha256-Jp8KqMHu2um0jvFxt/pk3gH/QOh0mgJJLElCnFVP3lg=") works on nixStable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change one character in the hash to make it invalid and then run nix-build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With nixUnstable, this gives you what I have written above

@turion
Copy link
Contributor

turion commented Oct 30, 2020

@alexarice Please have a look at agda/agda-categories#208 first, it was a mistake I think.

@alexarice
Copy link
Contributor Author

@turion was right, this was a mistake which has been fixed upstream

@alexarice alexarice closed this Oct 30, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102161 run on x86_64-linux 1

1 package built:
  • agdaPackages.agda-categories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@luc65r luc65r luc65r left review comments

Assignees
No one assigned
Labels
6.topic: agda 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexarice @turion @SuperSandro2000 @luc65r @veprbl