Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bunch of Jane Street OCaml packages at 0.13 #101124

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Conversation

bcc32
Copy link
Contributor

@bcc32 bcc32 commented Oct 20, 2020

Motivation for this change

I stumbled across these missing packages when trying to compile some OCaml projects using nix. These changes are hopefully straightforward. I'm also planning on making a PR for Jane Street packages version 0.14.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor

vbgl commented Oct 20, 2020

Thanks! FWIW, I’ve also given a look to 0.14: this seems tedious…

@vbgl
Copy link
Contributor

vbgl commented Oct 21, 2020

Merged “async_interactive” as d95b8c3, “posixat” and “shexp” as d2b8b92

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Oct 27, 2020
@vbgl vbgl merged commit 30ea1f1 into NixOS:master Oct 27, 2020
@bcc32 bcc32 deleted the jane-packages branch October 27, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants