Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: fix overridden videoDrivers #101176

Closed
wants to merge 1 commit into from
Closed

virtualbox: fix overridden videoDrivers #101176

wants to merge 1 commit into from

Conversation

DavHau
Copy link
Member

@DavHau DavHau commented Oct 20, 2020

Motivation for this change

I needed nvidia working in a virtual environment, and was wondering why it wouldn't activate.
It appeared, that if virtualbox guest is enabled, all other video drivers are getting disabled.
I think the author of this line probably assumed that other video drivers will never be needed inside virtualbox, but this is not true.
If PCI passthrough is set up, other driver are actually wanted.

Things done

append videoDrivers instead of overriding them.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/367

bachp
bachp approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The override seems to be there since the begining: 4adc99f

But I think we are good if removed.

@InLaw
Copy link
Contributor

InLaw commented Mar 28, 2021

Result of nixpkgs-review pr 101176 1

@stale
Copy link

stale bot commented Sep 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 26, 2021
@bachp
Copy link
Member

bachp commented Feb 3, 2022

Sorry I remembered this PR after merging #156245.

@bachp bachp closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DavHau @nixos-discourse @InLaw @bachp