Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.lab: wrap xdg-open to fix lab mr browse #101185

Merged
merged 1 commit into from Nov 26, 2020
Merged

gitAndTools.lab: wrap xdg-open to fix lab mr browse #101185

merged 1 commit into from Nov 26, 2020

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 20, 2020 •
edited

Motivation for this change

When executing lab mr browse in a GitLab repo xdg-open is missing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from dtzWill, marsam and kalbasit October 20, 2020 15:43
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 101185 run on x86_64-linux 1

1 package built:
  • gitAndTools.lab

@SuperSandro2000 SuperSandro2000 merged commit 48feb84 into NixOS:master Nov 26, 2020
@SuperSandro2000 SuperSandro2000 deleted the lab-xdg-open branch November 26, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

@marsam marsam Awaiting requested review from marsam

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @teto