ping @jonringer

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/430

oops sorry. Haven't had as much time for nix.

You have some conflicts :(

also, ofborg is failing:

anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-4/pkgs/development/node-packages/node-env.nix:3:1 called without required argument 'utillinux', 

@jonringer Rebased.

You have some conflicts :(

The nodePackages on master is updated quite frequently. I think it's better to at least have someone reviewed other parts before making tons of rebases.

Revert changes about utillinux and util-linux according to #108596
Unfortunately these two PR conflicts with each other. 😢 I'm not sure whether to merge these changes, they are not quite relevant.

@oxalica please fix the merge conflict now after the other PR got merged.

@SuperSandro2000 Rebased

still conflicts... wonder why there's so many conflicts

@jonringer Just due to update of adjacent vscode extensions. Rebased.
Another issue is that currently we prefer a mass single global nodePackages to reuse packages and reduce nixpkgs tree size, but it suffers from frequent merge conflicts and a total regenerate (mass diff) of the whole file in any PR touching it.
Related: #86776

frequent merge conflicts

That is an understatement. You get a merge conflict if anyone touches the file in the meanwhile.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 101179 run on x86_64-linux 1

Rebased. ping @jonringer

@oxalica you did not resolve all merge conflicts.

@SuperSandro2000 The new conflict is caused by #110813. Rebased again now.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 101179 run on x86_64-linux 1

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 101179 run on x86_64-darwin 1

error: --- Error -----------------------------------------------------------------------------------------------------------------------------------------------------------------------
nixbuilder for '/nix/store/armn7hc6ljgm5m1k33irk00qnlgbsrk1-vscode-lldb-adapter-1.6.1.drv' failed with exit code 101; last 10 log lines:
___cpp_closure_17014716006298275771 in liblldb-b0d0b3ec9b2efe72.rlib(cpp_closures.o)
ld: symbol(s) not found for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
error: aborting due to previous error
error: could not compile `codelldb`
To learn more, run the command again with --verbose.
error: --- Error -----------------------------------------------------------------------------------------------------------------------------------------------------------------------
nix1 dependencies of derivation '/nix/store/755mzzqcahpph93xkqqi5zpvd9hdix04-vscode-extension-vscode-lldb.drv' failed to build
error: --- Error -----------------------------------------------------------------------------------------------------------------------------------------------------------------------
nix1 dependencies of derivation '/nix/store/h7k7p26l4mkki727d5ql76draffhyfj3-env.drv' failed to build

@SuperSandro2000 Sorry but I don't have any darwin machine for test. Currently I just limit supported platforms to x86_64-linux only.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 101179 run on x86_64-linux 1