Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faust: fix build #101141

Merged
merged 2 commits into from Oct 20, 2020
Merged

Faust: fix build #101141

merged 2 commits into from Oct 20, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Oct 20, 2020 •
edited

Motivation for this change

@doronbehar Changed opencv to opencv2 and that got marked broken.
These commits remove opencv2 where it seems unneeded and changes it back to opencv where it is needed.

@doronbehar You implied you got errors in faust2jack when using opencv instead of opencv2.
I am not getting any, any idea why?
Are you ok with this change?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@magnetophon
faust2jack: use opencv instead of opencv2
c5277d0 
opencv2 is marked broken:
NixOS@5e68d20

This reverts NixOS@f68a003
@magnetophon
faust2jaqt: remove opencv2
5461c5f 
It's marked broken and it seems it wasn't needed in here in the first place.
NixOS@5e68d20
@doronbehar
Copy link
Contributor

doronbehar commented Oct 20, 2020 via email

@magnetophon
Copy link
Member Author

@doronbehar OK, thanks!

@doronbehar doronbehar merged commit 4d7925f into NixOS:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @doronbehar