nixos/activation: expose activation scripts #102320
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of a review or comment? 😄 @worldofpeace |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
@MatthewCroughan could you explain (to me or to anyone not familiar with activation Nix code, how does this change help? What do you mean by "access the activation scripts once they've been set"? |
stale
bot
removed
the
2.status: stale
|
This seems to allow overriding the activation script. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently, you can't access the activation scripts once they've been set (try eval --json config.system.activationScripts). This makes them accessible, in a non-breaking way.