Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agda-categories: Unbreak the build (trivial hash change) #102334

Merged
merged 1 commit into from Nov 7, 2020
Merged

agda-categories: Unbreak the build (trivial hash change) #102334

merged 1 commit into from Nov 7, 2020

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Nov 1, 2020

Apparently, v0.1.4 was released twice. The current version of the build points to the first edition of v0.1.4, which is no longer attached to the tag "v0.1.4" on GitHub. Hence currently, downloading fails. This commit adjusts the hash to appropriately refer to the second edition of v0.1.4.

I could not test this fix for lack of memory.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@iblech
agda-categories: fix hash
efa79e6 
Apparently, v0.1.4 was released twice. The current version of the build
points to the first edition of v0.1.4, which is no longer attached to
the tag "v0.1.4" on GitHub. Hence currently, downloading fails.
This commit adjusts the hash to appropriately refer to the second
edition of v0.1.4
@ofborg ofborg bot requested a review from alexarice November 1, 2020 10:05
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102334 run on x86_64-darwin 1

1 package built:
  • agdaPackages.agda-categories

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 1, 2020 •
edited

Result of nixpkgs-review pr 102334 run on x86_64-linux 1

1 package failed to build:
  • agdaPackages.agda-categories

Manually building works...

alexarice
alexarice approved these changes Nov 1, 2020
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change works for me, I can't verify that the old version is definitely broken as I think I have it cached somewhere and can't work out how to get rid of it

@iblech
Copy link
Contributor Author

iblech commented Nov 2, 2020

Thank you for the quick review, @alexarice! I obtained the correct hash using:

nix-prefetch-git https://github.com/agda/agda-categories v0.1.4

This command should not use any cache.

To others following along: The failures reported by @SuperSandro2000 are spurious, probably because compilation failed because there was not enough memory. As @alexarice confirmed that it works, I believe this is good for merge!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/280

@AndersonTorres AndersonTorres merged commit cad2568 into NixOS:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarice alexarice alexarice approved these changes

Assignees
No one assigned
Labels
6.topic: agda 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@iblech @SuperSandro2000 @nixos-discourse @alexarice @veprbl @AndersonTorres