pidgin: 2.13.0 -> 2.14.1 #102318
Closed
pidgin: 2.13.0 -> 2.14.1 #102318
+50
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
-Build console UI.............. : yes
+Build console UI.............. : noI'm not sure if people used it. I didn't even know about it :-) |
It disappeared in the parent commit.
vcunat
approved these changes
Nov 1, 2020
|
Result of 12 packages failed to build:
14 packages built:
|
|
I got no failures 🤷🏽 |
|
... so perhaps you could find logs of those failures? |
|
skype4pidgin.log telegram-purple.log toxprpl.log but I am rerunning because this looks like some unrelated failure. |
|
Result of 7 packages failed to build:
19 packages built:
pidgin-msn-pecan.log pidgin-osd.log pidgin-sipe.log purple-facebook.log purple-lurch.log purple-matrix.log telegram-purple.log |
|
That's really weird. I believe |
|
Result of 2 packages failed to build:
1 package built:
|
|
Result of 26 packages built:
|
|
Result of 2 packages failed to build:
1 package built:
|
SuperSandro2000
requested changes
Feb 9, 2021
| # python2 is optional but Pidgin does depend on it (and python3 won't be accepted in 2.x) | ||
| buildInputs = [ glib ncurses libxml2 python2 ]; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
stdenv.lib got recently deprecated.
|
|
||
| outputs = [ "out" "dev" ] ++ lib.optional docs "devdoc"; | ||
|
|
||
| nativeBuildInputs = [ meson ninja pkgconfig ] |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ meson ninja pkgconfig ] | |
| nativeBuildInputs = [ meson ninja pkg-config ] |
| @@ -0,0 +1,42 @@ | |||
| { stdenv, lib, fetchurl, meson, ninja, pkgconfig, python2 | |||
There was a problem hiding this comment.
Suggested change
| { stdenv, lib, fetchurl, meson, ninja, pkgconfig, python2 | |
| { stdenv, lib, fetchurl, meson, ninja, pkg-config, python2 |
|
What's the status of this PR? |
|
Stuck. The update would break darwin build, and I don't have a good means of debugging that. The only way I could think about was to only update on linux. EDIT: I see the build got broken recently on darwin (in nixpkgs master), but that issue should be easy. |
|
@magnetophon Are you still interested in getting this PR merged? I came up with Luflosi@6b22ff9, which compiles fine both on macOS and Linux. Feel free to take any of my changes and adapt them for this PR. |
|
@Luflosi Thanks! I don't use pidgin anymore either. |
|
OK, let me take over in #121794 (WIP). I'll cherry-pick your update later, and test it on my x86_64 NixOS. I'm not really using pidgin too much, but it's running all the time. |
|
@vcunat Thanks! |
|
It looks like #121794 didn't included update before merge 😢 and we still have only 2.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Closes #95296
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)