New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various issues with MinGW build #9
Conversation
Hmm I have a cmake branch based on @PeterN cmake branch. I should probably PR it. |
LGTM now from reading and Linux compile, but I don't have a Windows build env. |
Oh for windows it's easy, currently MSVC is not supported, only MinGW. |
I checked MinGW (both 32bit and 64bit) and it works. |
OK, I restored compile flags from |
Ok, grfcomm warnings are for release builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me
src/data.cpp
Outdated
@@ -1148,6 +1148,8 @@ FILE*_myfopen(files file, bool write){ | |||
exit(EDATA); | |||
} | |||
} else | |||
#else | |||
(void)write; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use tabs for indentation ;) (noticed it with glx22#2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ok now
Most compilation warnings fixed. (Almost) no changes in behaviour - added an obviously missing
break
. Other than that, I've tried to keep to the lovely codestyle.Two remaining warnings that I haven't quite figured out, as they would require some thought on my part:
(Because the message isn't clear, they correspond to
grfcodec/src/grfcomm.cpp
Line 113 in e8b95a3
grfcodec/src/grfcomm.cpp
Line 51 in e8b95a3