Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cde: update expression #102299

Merged
merged 1 commit into from Nov 1, 2020
Merged

cde: update expression #102299

merged 1 commit into from Nov 1, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Nov 1, 2020

The old Github repository was deleted; usnistgov/corr-CDE will be used instead.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 1, 2020

Result of nixpkgs-review pr 102299 run on x86_64-linux 1

1 package failed to build:
  • cde
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/0k4dvrsx4z8d2mvjhd69ls1piw1nip24-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
building
build flags: SHELL=/nix/store/k8p54jg8ipvnfz435mayf5bnqhw4qqap-bash-4.4-p23/bin/bash
cd strace-4.6 && ./configure
/nix/store/k8p54jg8ipvnfz435mayf5bnqhw4qqap-bash-4.4-p23/bin/bash: ./configure: /bin/sh: bad interpreter: No such file or directory
make: *** [Makefile:15: strace-4.6/Makefile] Error 126

@AndersonTorres
Copy link
Member Author

Oh hell, a mere update will imply a patch...

The old Github repository (pgbovine/CDE) was deleted; usnistgov/corr-CDE is an
alternative fork.
@AndersonTorres AndersonTorres merged commit 6123e8d into NixOS:master Nov 1, 2020
@AndersonTorres AndersonTorres deleted the update-cde branch November 1, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants